New ProviderFactory interface#11111
Open
fulghum wants to merge 2 commits into
Open
Conversation
fulghum
force-pushed
the
fulghum/relation_name_validation
branch
2 times, most recently
from
6bd7d2b to
9b1b5b5
Compare
Contributor
|
@fulghum DOLT
|
Contributor
Contributor
fulghum
force-pushed
the
fulghum/relation_name_validation
branch
from
9b1b5b5 to
9128243
Compare
fulghum
force-pushed
the
fulghum/relation_name_validation
branch
from
9128243 to
62651cf
Compare
fulghum
force-pushed
the
fulghum/relation_name_validation
branch
from
62651cf to
4057ea3
Compare
Contributor
zachmu
reviewed
May 29, 2026
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
General idea seems very workable
| // TODO: This is currently used by Doltgres to wrap databases, but we should be able | ||
| // to completely remove this in a future refactoring if Doltgres overrides | ||
| // GetTableInsensitive(). | ||
| SchemaWrap func(requestedName string, db Database) sql.DatabaseSchema |
|
|
||
| pro.InitDatabaseHooks = append(pro.InitDatabaseHooks, statspro.NewInitDatabaseHook(sc)) | ||
| pro.DropDatabaseHooks = append(pro.DropDatabaseHooks, statspro.NewDropDatabaseHook(sc)) | ||
| if adder, ok := se.GetUnderlyingEngine().Analyzer.Catalog.DbProvider.(interface { |
Member
There was a problem hiding this comment.
Probably want a named interface for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
ProviderFactoryinterface that allows Doltgres to extend database behavior.Depends on: dolthub/go-mysql-server#3563